Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename version variable to kubernetes_version #25

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

TaopaiC
Copy link
Contributor

@TaopaiC TaopaiC commented Mar 22, 2019

Since "version" name is reserved word in module configuration block, rename it to "kubernetes_version" and "node_exporter_version" .

ref: https://www.terraform.io/docs/configuration/variables.html#declaring-an-input-variable

Copy link
Contributor

@smalltown smalltown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smalltown smalltown merged commit 3432140 into getamis:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants