upgrade eks module #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smalltown
commented
Apr 1, 2019
•
smalltown
commented
- upgrade eks module for supporting latest version
- delete worker-asg, worker-spot, worker-common module, creating eks-worker module by AWS launch template to support spot/on-demand EC2 instance type
owensengoku
approved these changes
Apr 1, 2019
modules/aws/kube-worker/ami.tf
Outdated
| @@ -0,0 +1,39 @@ | |||
| locals { | |||
| ami_owner = "595879546273" | |||
modules/aws/eks/variables.tf
Outdated
| default = "" | ||
| } | ||
|
|
||
| variable "cidr_access_eks_endpoint" { |
There was a problem hiding this comment.
How about to rename cidr_access_eks_https for consistency with cidr_access_worker_ssh?
modules/aws/eks/variables.tf
Outdated
| default = "./terraform" | ||
| } | ||
|
|
||
| variable "write_kubeconfig" { |
modules/aws/eks/variables.tf
Outdated
| default = true | ||
| } | ||
|
|
||
| variable "write_aws_auth_config" { |
There was a problem hiding this comment.
rename to aws_auth_config_output_flag ?
| @@ -0,0 +1,43 @@ | |||
| locals { | |||
| kubeconfig_name = "${var.kubeconfig_name == "" ? "${var.cluster_name}" : var.kubeconfig_name}" | |||
|
|
||
| contexts: | ||
| - context: | ||
| cluster: ${kubeconfig_name} |
There was a problem hiding this comment.
Of course, it does not matter to use the same name, but I guess could consider to use ${cluster_name} here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.