Add Elastikube - a EKS-like Kubernetes service built with pure terraform #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalltown
reviewed
Jul 24, 2018
| type = "list" | ||
| default = [] | ||
|
|
||
| description = <<EOF |
There was a problem hiding this comment.
This field only can be filled in private subnet id, right?
There was a problem hiding this comment.
For the security concern, yes.
aws/kube-etcd/role.tf
Outdated
| "Action" : [ | ||
| "s3:GetObject" | ||
| ], | ||
| "Resource": "arn:aws:s3:::*", |
There was a problem hiding this comment.
Limit the get permission for only the specific s3 bucket?
aws/kube-master/lb.tf
Outdated
|
|
||
| ingress { | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] |
There was a problem hiding this comment.
How about only the master vpc cidr can access the lb?
| @@ -0,0 +1,50 @@ | |||
| resource "aws_security_group" "workers" { | |||
There was a problem hiding this comment.
Why worker sg put in the mater folder?
alanchchen
force-pushed
the
feature/elastikube
branch
from
506d9f9 to
05b772b
Compare
added 8 commits
July 25, 2018 14:43
…ort load balancers in worker module
alanchchen
force-pushed
the
feature/elastikube
branch
from
05b772b to
c5a4061
Compare
alanchchen
force-pushed
the
feature/elastikube
branch
from
383b13a to
50d8677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.