Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert now working inside quickview #4

Open
getdatakick opened this issue Apr 5, 2018 · 2 comments
Open

Alert now working inside quickview #4

getdatakick opened this issue Apr 5, 2018 · 2 comments
Labels
bug ps17 Affects prestashop 17 only

Comments

@getdatakick
Copy link
Owner

javascript is not loaded

@getdatakick getdatakick added the bug label Apr 5, 2018
@getdatakick getdatakick changed the title [PS17] - Alert now working inside quickview [PS17] Alert now working inside quickview Apr 5, 2018
@backamblock
Copy link

is this fixed already?

@getdatakick
Copy link
Owner Author

This is primarily bug in ps17. They newly load and compose content for quickview using javascript, instead of iframe. While this is a good approach, they forget to include/run javascript from product page as well, so any included content that depends on this javascript will not work.

This issue affects many modules, not just pricealert. So I believe prestashop team will address it in the future (maybe they already have).

To fix it on my side, it would require a significant redesign of module. So I'm putting this on ice, hoping that ps will fix the root cause

@getdatakick getdatakick changed the title [PS17] Alert now working inside quickview Alert now working inside quickview Aug 2, 2018
@getdatakick getdatakick added the ps17 Affects prestashop 17 only label Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ps17 Affects prestashop 17 only
Projects
None yet
Development

No branches or pull requests

2 participants