Skip to content
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.

Make CSharp Runner build Configuration and Platform Configurable #131

Closed
mflick89 opened this issue Jun 11, 2018 · 5 comments
Closed

Make CSharp Runner build Configuration and Platform Configurable #131

mflick89 opened this issue Jun 11, 2018 · 5 comments
Assignees

Comments

@mflick89
Copy link
Contributor

mflick89 commented Jun 11, 2018

Problem:
Current CSharp Runner will always build C# gauge tests as "Any CPU" and "Debug" by default.
This can cause difficulties when wanting to test some x64 environments or custom configurations.

Proposed Solution:
Add variables to csharp.properties that allow users to define the Configuration and Platform of the build run by the CSharp Runner.

Example:
The build configuration when running tests for the Gauge project
GAUGE_CSHARP_PROJECT_CONFIG = Debug

The build platform when running tests for the Gauge project
GAUGE_CSHARP_PROJECT_PLATFORM = Any CPU

@mflick89
Copy link
Contributor Author

I'd like to assign this issue to myself.

@sriv
Copy link
Member

sriv commented Jun 14, 2018

Thanks for raising this. Looking at the PR now.

@sriv
Copy link
Member

sriv commented Jun 15, 2018

should be available in nightly >= 14/06/2018

@sswaroopgupta
Copy link
Contributor

Question

GAUGE_CSHARP_PROJECT_CONFIG = Debug

GAUGE_CSHARP_PROJECT_PLATFORM = Any CPU

Should these configurations be available in csharp.properties when a new project is created?

@mflick89
Copy link
Contributor Author

It would be nice to have them there.
It is not required since the code will default these values if they are missing, but it would be nice to have them there by default to make it obvious to the user that the options are available.

@ghost ghost removed the ready for QA label Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants