Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore events when cache isn't init #1896 #2019

Merged
merged 11 commits into from
Jul 15, 2021

Conversation

sriv
Copy link
Member

@sriv sriv commented Jun 17, 2021

No description provided.

Signed-off-by: sriv <srikanth.ddit@gmail.com>
@github-actions
Copy link
Contributor

Benchmark Results

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 185% 316576 0:20.36 0
c532320 188% 316540 0:20.17 0
c93f7af 182% 324672 0:20.33 0
e219012 179% 345596 0:18.04 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 183% 355184 0:23.08 0
c532320 183% 303728 0:22.61 0
c93f7af 153% 362648 0:37.51 0
e219012 151% 327640 0:23.18 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 181% 397856 0:13.15 0
c532320 174% 384524 0:13.73 0
c93f7af 174% 385536 0:14.13 0
e219012 176% 361724 0:13.17 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 178% 394976 0:20.54 0
c532320 178% 374068 0:20.26 0
c93f7af 166% 639544 0:30.80 0
e219012 183% 633964 0:30.41 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 179% 351068 0:13.29 0
c532320 170% 343216 0:14.42 0
c93f7af 163% 341344 0:15.11 0
e219012 170% 305344 0:16.34 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 180% 376804 0:18.33 0
c532320 182% 355644 0:20.04 0
c93f7af 179% 558492 0:33.83 0
e219012 181% 585208 0:32.59 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 181% 318024 0:17.65 0
c532320 181% 338348 0:18.11 0
c93f7af 147% 296200 0:30.25 0
e219012 167% 322808 0:25.76 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 184% 318832 0:21.98 0
c532320 184% 340820 0:20.92 0
c93f7af 158% 341744 0:31.93 0
e219012 168% 313228 0:30.45 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 179% 388428 0:21.85 0
c532320 177% 349640 0:21.11 0
c93f7af 166% 619168 0:33.39 0
e219012 181% 579700 0:35.50 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@sriv sriv force-pushed the 1896_filewatcher_events_handle_error branch from 1ae219e to a0fb9d1 Compare June 29, 2021 10:06
@zabil
Copy link
Member

zabil commented Jul 8, 2021

@sriv anything pending in this?

zabil
zabil previously approved these changes Jul 8, 2021
@sriv
Copy link
Member Author

sriv commented Jul 11, 2021

@zabil waiting for some feedback in #1896

Signed-off-by: sriv <srikanth.ddit@gmail.com>
@gaugebot
Copy link

gaugebot bot commented Jul 13, 2021

@sriv Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@sriv sriv marked this pull request as draft July 13, 2021 16:28
@sriv sriv marked this pull request as ready for review July 14, 2021 17:01
@sriv sriv merged commit 9805a2b into master Jul 15, 2021
@sriv sriv deleted the 1896_filewatcher_events_handle_error branch July 15, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants