-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow custom environment directory, fixes #2025 #2057
Conversation
Signed-off-by: sriv <srikanth.ddit@gmail.com>
@sriv Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Signed-off-by: sriv <srikanth.ddit@gmail.com>
#2047 can be reviewed and merged before this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the documentation with info about this after merging it?
* introduce gauge_data_dir allow csv/txt data files to be in subdirectory, configured by gauge_data_dir fixes #2046 Signed-off-by: sriv <srikanth.ddit@gmail.com> * print debug when loading from gauge_data_dir, warning when setting incorrect gauge_data_dir Signed-off-by: sriv <srikanth.ddit@gmail.com> * better error message when table is not resolved from gauge_data_dir Signed-off-by: sriv <srikanth.ddit@gmail.com> * add tests for gauge_data_dir resolution fixed some tests/code lint Signed-off-by: sriv <srikanth.ddit@gmail.com> * Update util/fileUtils.go Co-authored-by: Zabil Cheriya Maliackal <zabil@users.noreply.github.com> Signed-off-by: sriv <srikanth.ddit@gmail.com> Co-authored-by: Zabil Cheriya Maliackal <zabil@users.noreply.github.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
@zabil - pushed docs changes via getgauge/docs.gauge.org#331 (please review :) ) See: |
This PR allows
env
folder in a gauge project to be configured.IMPORTANT - this allows changing the
env
directory to a custom name/location. This does not change the way environments function, i.e.gauge run --env=foo
will continue to function.Things to note:
env
directorygauge_env_dir
environment variable or usingEnvironmentDir
key in the project'smanifest.json
.manifest.json
found, gauge will default toenv
.gauge_env_dir
env variable ->manifest.json
-> defaultenv
.Signed-off-by: sriv srikanth.ddit@gmail.com