Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error 500 page exposes site details to visitors #1064

Closed
gitname opened this issue Sep 24, 2016 · 3 comments
Closed

Error 500 page exposes site details to visitors #1064

gitname opened this issue Sep 24, 2016 · 3 comments

Comments

@gitname
Copy link

gitname commented Sep 24, 2016

Even with the Display errors option set to No...

image

..., the Error 500 page (example shown below) still exposes more information than I would like it to while in Production.

Specifically, it does 2 things I want to change:

  1. It has the known appearance of a Grav Error 500 page (providing a clue to the visitor that the site uses Grav and is vulnerable to any outstanding vulnerabilities in Grav)
  2. It shows the PHP error information (providing a clue to the visitor of potential vulnerabilities in the site)

image

I would like to be able to customize the page, to disable it completely, or for there to be a Grav option I can use to indicate whether I want it to contain the PHP error information or not.

@Perlkonig
Copy link
Contributor

I concur. When "display errors" is set to false, it should return a bare 500 and let the web server handle it. I'm looking through the source code but don't understand Whoops enough to know what the alternatives are. What would happen if you just returned Handler::Quit in this function? Why does Grav want to handle it in the first place? I'll do a little digging.

@Perlkonig
Copy link
Contributor

A bare Handler::Quit seems to work. Something to consider, anyway.

@rhukster
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants