Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable self upgrade #3374

Open
makuhama opened this issue May 31, 2021 · 1 comment
Open

Option to disable self upgrade #3374

makuhama opened this issue May 31, 2021 · 1 comment
Assignees

Comments

@makuhama
Copy link

This is a follow-up to #3297. With the help of @mahagr I succeeded in packaging Grav for Arch Linux. The package already contains a patched GPM that doesn't allow gpm selfupgrade. But that is only half the Story. I also need to prevent upgrading Grav via admin plugin. I was planning to also deliver a package for the admin plugin - patched in a way to disable upgrading Grav from the admin plugin. But here it gets nasty:

  1. The admin plugin is dependent on three other plugins. So I have to bundle and watch all four plugins (admin + 3 dependencies) and deliver a new package any time one is released.
  2. The patched admin plugin also needs to prevent upgrading itself and the 3 dependencies - for obvious reasons. Haven't investigated yet whether this is doable and how much effort.

So I'm kindly asking for an option that prevents any self upgrade of Grav - be it via gpm or via admin plugin.

I know this is a very special request for 2 or 3 packagers worlwide :-)

I'm aware that people still can upgrade manually (downloading ZIP files and copying around stuff in the filesystem). They can also manually toggle the above mentioned option. But IMHO then these people are completely on their own.

@mahagr
Copy link
Member

mahagr commented Jun 1, 2021

Upgrading plugins and Grav will already be disabled if you use symlinks. So if the plugins are outside of the Grav root, but symlinked to the site, updating them will be prevented. This includes manual upgrades, though.. you can always remove symlink manually and to the upgrade in that way.

@mahagr mahagr self-assigned this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants