-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tiny fixes in Debugger #43
Conversation
TracyDebugger::$productionMode = self::DETECT; | ||
} elseif ($mode == strtolower('production')) { | ||
} elseif ($mode === 'production') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That strtolower
was definitely meant for $mode
but your fix is too strict, maybe:
$mode = strtolower($config->get('system.debugger.mode'));
So you can then just do $mode == 'production'
.
I wouldn't do those |
I'll discuss with the team, but your changes is probably fine. We're definitely interested in any and all optimizations. Every little bit helps and if you find any other things, even if they are minor, please submit other pull requests. It's great having a fresh pair of eyes on it. thanks! |
No description provided.