Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to home for multilingual sites #47

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix link to home for multilingual sites #47

merged 1 commit into from
Sep 7, 2023

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Sep 4, 2023

Summary

Uses a language-specific relative URL as link target of the brand logo in the nav bar instead an absolute URL to /.

Motivation

With this change users aren't inadvertently redirected to the default language.

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

h-enk
h-enk approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@h-enk h-enk merged commit dc3e24e into thuliteio:main Sep 7, 2023
@salim-b salim-b deleted the fix-home-link branch September 7, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-enk h-enk h-enk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salim-b @h-enk