Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add editorconfig rules for md-files #346

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

JanKru
Copy link
Contributor

@JanKru JanKru commented Jan 14, 2024

Summary

If you set trim_trailing_whitespace = true, it will no longer be possible to start a new line with two blank lines in the markdown files.

Basic example

Try it in example.md. I used vs code with editorconfig plugin.

Motivation

Would be nice to have new lines. Added specific rules for md @h-enk .

Checks

  • [ x ] Read Create a Pull Request
  • [ x ] Supports all screen sizes (if relevant)
  • [ x ] Supports both light and dark mode (if relevant)
  • [ x ] Passes npm run test

@h-enk
Copy link
Member

h-enk commented Jan 16, 2024

[..], it will no longer be possible to start a new line with two blank lines in the markdown files.

Why would you want that (is one blank line not enough) /what's the use case?

@JanKru
Copy link
Contributor Author

JanKru commented Jan 16, 2024

Thanks for the reply :)

One example, if I write on a markdown-file without 2 spaces after the end of First line line

#markdown
First line
Second line
# rendered
First line Second line

# markdowm
First line

Second line
# rendered
First line

Second line

So if I want to have

# rendered
First line 
Second line

as outcome I must write it as

#markdown
First line   
Second line

with two spaces after First line
which is not possible with current editorConfig?

@h-enk
Copy link
Member

h-enk commented Jan 16, 2024

Ah, clear — I get it now. Thx!

I'll get back to you later

@h-enk h-enk merged commit ff2eadc into thuliteio:main Mar 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants