Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File browser: pre-select current page #6458

Closed
mrflix opened this issue May 22, 2024 · 7 comments · Fixed by #6554
Closed

File browser: pre-select current page #6458

mrflix opened this issue May 22, 2024 · 7 comments · Fixed by #6554
Assignees
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone

Comments

@mrflix
Copy link
Contributor

mrflix commented May 22, 2024

Description

When I use the link dialog to link to a file, the file browser starts at the root level.

Expected behavior
Since files in Kirby are grouped with the pages their used in, I'd expect the browser to start out at the current page's level, listing the files of that page.

Screenshots
I'm in material/bubble-crasher. The file browser starts at the root:

CleanShot 2024-05-22 at 17 05 12

I'd expect it to start with the current page active:

CleanShot 2024-05-22 at 17 05 24

100+ pages example
Linking text to a pdf file in writer from within a blog post on a website with 100+ posts shows that the user experience is very bad.

CleanShot.2024-05-22.at.17.13.25.mp4

Your setup

Kirby Version
4.2.0

@afbora
Copy link
Member

afbora commented May 22, 2024

I think this is a feature request rather than a bug.

@gbdesign2023
Copy link

gbdesign2023 commented May 22, 2024

However, I don't think that's a bug. I see it more as an additional feature. Personally, I think it is even beneficial to display the root menu. For a nested structure, the integrated search function is helpful to avoid clicks.

@afbora
Copy link
Member

afbora commented May 22, 2024

Also I think this idea can be solve with query support: https://feedback.getkirby.com/574

@mrflix mrflix changed the title Link dialog not starting out at current page File browser not starting out at current page May 22, 2024
@mrflix mrflix changed the title File browser not starting out at current page File browser doesn't start at current page May 23, 2024
@mrflix
Copy link
Contributor Author

mrflix commented May 23, 2024

Personally, I think it is even beneficial to display the root menu.

I can't follow you here. In the screenrecording I have do dig through a large page-tree to find the page I'm currently working on, just to link to a file that I just uploaded there. That's in the writer field. For comparison, in a textarea, the file picker dialog shows me the files of the page.

@mrflix
Copy link
Contributor Author

mrflix commented May 23, 2024

Also I think this idea can be solve with query support: https://feedback.getkirby.com/574

Will it be possible to adjust the starting location of the file dialog for file-linking inside the writer field?

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label May 26, 2024
@mrflix
Copy link
Contributor Author

mrflix commented Jun 25, 2024

I would like to point out once again the strange behavior of the file link dialog. I am in the process of showing a customer how to link files. It just doesn't suit Kirby at all that the file link dialog starts on the root level instead of listing the current page's files.

Kirby is organizing files by page. The dialog doesn't contain an upload button. So the editor has to upload the file to the page before creating the link. Because of that they always have to search for their current page in the page structure.

@mrflix
Copy link
Contributor Author

mrflix commented Jul 2, 2024

I'm currently updating another website to Kirby 4 and have to jump the hops to link to a file from within a large page structure. Join me on the ride:

CleanShot.2024-07-02.at.11.38.44.mp4

@distantnative distantnative changed the title File browser doesn't start at current page File browser: pre-select current page Jul 12, 2024
@distantnative distantnative self-assigned this Jul 21, 2024
@distantnative distantnative linked a pull request Jul 21, 2024 that will close this issue
5 tasks
@bastianallgeier bastianallgeier added this to the 4.4.0 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants