Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] - Gallery block: wrong css applied to unrelated fields #6747

Closed
manuelmoreale opened this issue Oct 15, 2024 · 2 comments · Fixed by #6838
Closed

[Panel] - Gallery block: wrong css applied to unrelated fields #6747

manuelmoreale opened this issue Oct 15, 2024 · 2 comments · Fixed by #6838
Assignees
Milestone

Comments

@manuelmoreale
Copy link

Description

In a gallery block, some extra css is applied to unrelated fields because of a css conflict.

For example:
Screenshot 2024-10-15 at 5 30 51 PM

This toggle has an extra gap in between the buttons because it is inheriting a grid-gap value set on the .k-block-type-gallery ul selector.

Screenshot 2024-10-15 at 5 32 24 PM

Expected behavior
That extra CSS shouldn't be applied to unrelated items.

To reproduce

Add a toggle field to a gallery block and the bug should be there. I didn't test this with other types of field but it should be there on all fields that use an ul

Your setup

4.4.0

@distantnative
Copy link
Member

distantnative commented Oct 15, 2024

  • Make CSS selector very specific
  • Check other blocks if they face similar problems

@manuelmoreale
Copy link
Author

Just noticed that the same selector is also messing up other things such as the pages selector inside a link field

Screenshot 2024-12-06 at 6 23 39 AM

@distantnative distantnative self-assigned this Dec 6, 2024
@distantnative distantnative added this to the 4.6.0 milestone Dec 6, 2024
@distantnative distantnative linked a pull request Dec 6, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants