Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip XML prefix from field names in .../diffs #410

Closed
matthew-white opened this issue Oct 1, 2021 · 0 comments · Fixed by #412
Closed

Strip XML prefix from field names in .../diffs #410

matthew-white opened this issue Oct 1, 2021 · 0 comments · Fixed by #412

Comments

@matthew-white
Copy link
Member

I noticed that this screenshot from the forum shows an orx: prefix for a field name within a submission diff:

central-submission-diff

We strip the XML prefix in other places, so I think we should do so here as well. In particular, the Frontend code compares the field name in the diff with the field names from the .../fields endpoint. The .../fields endpoint returns names without prefixes, so those names won't match a field name in the diff if it has a prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strip xml prefix (e.g. orx:) from field names in diffs getodk/central-backend
1 participant
@matthew-white