isFalse() and non-string query parameters

[matthew-white]

isFalse() throws an error if a query parameter is not blank or string:

TypeError: x.toLowerCase is not a function
  File "/usr/odk/lib/util/http.js", line 22, col 43, in isFalse
    const isFalse = (x) => (!isBlank(x) && (x.toLowerCase() === 'false'));
  File "/usr/odk/lib/util/db.js", line 391, col 9, in Function.fromSubmissionCsvRequest
    if (isFalse(query.groupPaths))
  File "/usr/odk/lib/resources/submissions.js", line 270, col 42, in <anonymous>
    const options = QueryOptions.fromSubmissionCsvRequest(query);
  File "/usr/odk/lib/util/http.js", in runMicrotasks
  File "node:internal/process/task_queues", line 96, col 5, in processTicksAndRejections

For example, we've seen this error for the (invalid) query parameter deletedFields=%5B%22false%22%2C%22false%22%5D. isFalse() seems to work fine for valid user input, but it'd be nice if it were more resilient to user error. For example, Express allows a query parameter to be an array, but isFalse() doesn't account for that possibility.

isTrue() should probably be updated in a similar way as isFalse().

[JosephVoid]

Hi @matthew-white,

I'd like to work on this. But I couldn't understand what the purpose of the isTrue and isFalse functions are.
Plus, just on top of my head, wouldn't typeof x === string be a solution to this.

Thanks

[matthew-white]

Hi @JosephVoid! isTrue() and isFalse() just check whether the value of a particular query parameter is true or false. I guess the main thing the functions do is checking that in a case-insensitive way: the values TRUE and FALSE are also allowed. I think you're probably right that typeof x is all that's needed!

[JosephVoid]

Hi @matthew-white ,
I've created a PR, let me know what you think.
Thanks