Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/entities/relevant to conflict flag #1028

Conversation

sadiqkhoja
Copy link
Contributor

@sadiqkhoja sadiqkhoja commented Oct 16, 2023

Part of getodk/central#504

What has been done to verify that this works as intended?

Added tests

Why is this the best possible solution? Were any other approaches considered?

The name of querystring parameter could be shorter but we came to consensus on relevantToConflict in Slack

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

None

Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.

Yes

Before submitting this PR, please make sure you have:

  • run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@sadiqkhoja sadiqkhoja force-pushed the features/entities/relevant-to-conflict-flag branch from 7787851 to ceff8d3 Compare October 17, 2023 18:53
@sadiqkhoja sadiqkhoja marked this pull request as ready for review October 17, 2023 18:58
@sadiqkhoja sadiqkhoja requested review from ktuite and matthew-white and removed request for ktuite October 17, 2023 19:03
Copy link
Member

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at tests yet, but I thought I'd start with these comments. It's looking good so far!

lib/data/entity.js Outdated Show resolved Hide resolved
lib/data/entity.js Outdated Show resolved Hide resolved
lib/data/entity.js Outdated Show resolved Hide resolved
lib/data/entity.js Outdated Show resolved Hide resolved
+ change the definition of lastGoodKnow version
Copy link
Member

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few places where we need more test coverage, but besides that, I only have small suggestions to make. ✅ Entity updates via submission are a complex feature, so I really think we'll benefit from having excellent test coverage.

lib/data/entity.js Show resolved Hide resolved
lib/data/entity.js Show resolved Hide resolved
lib/data/entity.js Outdated Show resolved Hide resolved
lib/data/entity.js Outdated Show resolved Hide resolved
lib/data/entity.js Outdated Show resolved Hide resolved
test/unit/data/entity.js Outdated Show resolved Hide resolved
test/unit/data/entity.js Outdated Show resolved Hide resolved
test/integration/api/entities.js Outdated Show resolved Hide resolved
lib/data/entity.js Show resolved Hide resolved
test/integration/api/entities.js Outdated Show resolved Hide resolved
@sadiqkhoja sadiqkhoja merged commit 5b386ee into getodk:master Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants