Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user if iframe is loading #236

Closed
matthew-white opened this issue Jul 24, 2019 · 0 comments · Fixed by #534
Closed

Inform user if iframe is loading #236

matthew-white opened this issue Jul 24, 2019 · 0 comments · Fixed by #534
Labels
needs discussion Discussion needed before work can begin

Comments

@matthew-white
Copy link
Member

The "Decrypt and Download" modal contains an iframe. The iframe is not visible to the user, but it must load before the user can download their data. Right now if the user clicks the Download button, and the iframe has not loaded, nothing happens. Instead, we should inform the user if the iframe is loading. For example, we could disable the button so that the user doesn't try to click it until the iframe has finished loading. Alternatively, we could keep it enabled, but display an alert about the iframe if the user clicks the button before the iframe has finished loading.

@matthew-white matthew-white added the needs discussion Discussion needed before work can begin label Jul 24, 2019
matthew-white added a commit that referenced this issue Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Discussion needed before work can begin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant