5.42 Download encrypted submissions #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moving some styles from SubmissionList to SubmissionRow and shortening some HTML class names.
issa-tseng
approved these changes
Jul 22, 2019
matthew-white
commented
Jul 23, 2019
Making these changes, because it seems that it is not guaranteed that the Problem response will be wrapped in a <pre> element. Also making sure to wait for the iframe to load in each test that requires that.
The most important changes are:
- If the form is submitted, and a Problem check is already scheduled,
do not cancel the check; simply set this.problemChecks.
- Set this.timeoutId to null after the last Problem check.
Also removing the `return` from replaceIframeBody(), which was unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.