-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Single Sign-on with OpenID Connect #449
Comments
Adventures trying SSO in dev (july 25)
Note: would be nice to be rebased with master soon to get newer database migrations Ran on the backend: Ran on the frontend: Note: At first, things didn't quite run properly and I wasn't sure why. I got hung up on this issue for a while: On my mac, something is already running on port 5000 so i changed it to another port in Appreciated that the fake oidc server gave me useful tips when in entered bad credentials. |
The three PRs above are merged, and the QA team is now taking a look at this issue, so I'm going to go ahead and close. There are still some related to-dos that I've filed as separate issues: getodk/central-backend#976, getodk/central-backend#971, #477. |
Logging out on Chrome feels a bit tricky. There a few scenarios that theoretically go along with "do not centralize log out” release criteria but make it difficult to "really log out” and switch a user afterwards. Steps to reproduce:
One thing that is not present after logging out is the ability to choose an account to which I want to log in to (e.g. the second time I want to log in to a different account). So to change the user I need to find the account that I’m currently logged in the browser (it’s possible to make it that it’s not the one visible in the header) and log out of staging and then the option to choose a user appears while logging in. |
@alxndrsn @matthew-white @ktuite As mentioned above there are some issues with logging out and we're about to start regression testing so are these cases ok and they'll be fixed separately? Steps to reproduce:
After clicking continue the user is logged in without being asked to enter the password. |
I checked on Windows edge (on a virtual machine) where I don't allow saving password etc. and after logging out clicking continue also logs in the user without asking for the password. |
Following the Slack conversation, we are closing this pull request as tested with success. |
Tested with success! |
Creating an issue to track work on SSO:
central
PRThe text was updated successfully, but these errors were encountered: