Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No properties in the form creating entities, in the draft section and form overview section clicking the arrow to show properties ("0 of x properties”) shows an empty space #463

Closed
dbemke opened this issue Aug 21, 2023 · 4 comments · Fixed by getodk/central-frontend#845
Assignees
Labels
behavior verified Behavior has been manually verified entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@dbemke
Copy link

dbemke commented Aug 21, 2023

Problem description

If the users removes all properties in the form creating entities, in the draft section and form overview section clicking the arrow to show properties ("0 of x properties”) shows an empty space without any information.

Steps to reproduce the problem

(Steps 1, 2 are optional)

  1. Upload and publish a form creating entities with at least one saveto field.
  2. In the form remove the saveto column so that there are no properties.
  3. Create a draft of the new version of the form (without saveto fields).
  4. Click the arrow next to "0 of x properties”.

Screenshot

zeroproperties
After clicking the arrow:
nopropertiesunfild
verviewzeropropertiesunfold

Expected behavior

The arrow works as expected and it’s an edge case (having 0 properties) so I'm not sure what the expected should be but maybe showing some piece of information instead of an empty space would be more user-friendly.

Central version shown in version.txt

versions:
906addf (v2023.3.1)
+330132cf1ecb824b1fb88894287cb8edb5acefa5 client (v2023.3.0-2-g330132cf)
ba6ee474f431b48e885fb035c9266792f06d0ad7 server (v2023.3.1)

Browser version

Chrome 114.0.5735.198, Firefox 116.0.2

Other notes

A form without saveto fields - directors form version 1 in https://test.getodk.cloud/#/projects/436/forms/director%20entities

@dbemke dbemke changed the title Removing all properties in the form creating entities, in the draft section and form overview section clicking the arrow to show properties ("0 of x properties”) shows an empty space No properties in the form creating entities, in the draft section and form overview section clicking the arrow to show properties ("0 of x properties”) shows an empty space Aug 21, 2023
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Aug 21, 2023
@matthew-white matthew-white added entities Multiple Encounter workflows frontend Requires a change to the UI needs testing Needs manual testing labels Aug 21, 2023
@sadiqkhoja sadiqkhoja self-assigned this Aug 21, 2023
@sadiqkhoja sadiqkhoja moved this from 🕒 backlog to ✏️ in progress in ODK Central Aug 22, 2023
@matthew-white
Copy link
Member

I'm pretty sure that getodk/central-frontend#845 resolves this.

@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Aug 25, 2023
@matthew-white matthew-white linked a pull request Aug 25, 2023 that will close this issue
2 tasks
@sadiqkhoja
Copy link
Contributor

@getodk/testers this can be tested on staging environment

@dbemke
Copy link
Author

dbemke commented Aug 28, 2023

Tested with success!

1 similar comment
@srujner
Copy link

srujner commented Aug 29, 2023

Tested with success!

@srujner srujner added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

4 participants