Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style loading message for OData table #526

Closed
matthew-white opened this issue Oct 21, 2023 · 0 comments · Fixed by getodk/central-frontend#986
Closed

Style loading message for OData table #526

matthew-white opened this issue Oct 21, 2023 · 0 comments · Fixed by getodk/central-frontend#986
Assignees
Labels
frontend Requires a change to the UI styles Changes to CSS

Comments

@matthew-white
Copy link
Member

We show a loading message while waiting for OData on the Submissions page and the Entity Data page. Previously, that message was styled on the Submissions page: https://github.com/getodk/central-frontend/blob/f458048622177aac3af50a00bb4d23fc32dd27b5/src/components/submission/list.vue#L381-L398. However, now that we have a generic OdataLoadingMessage component that we also use on the Entity Data page, it looks like those styles have been orphaned. I don't think we currently style OdataLoadingMessage. It'd be good to move the orphaned styles into OdataLoadingMessage.

@matthew-white matthew-white added frontend Requires a change to the UI styles Changes to CSS labels Oct 21, 2023
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Apr 30, 2024
@ktuite ktuite moved this from 🕒 backlog to ✏️ in progress in ODK Central May 1, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires a change to the UI styles Changes to CSS
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

2 participants