Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative ordinal numbers in submissions table #641

Closed
dbemke opened this issue Apr 24, 2024 · 7 comments
Closed

Negative ordinal numbers in submissions table #641

dbemke opened this issue Apr 24, 2024 · 7 comments
Assignees
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified bug

Comments

@dbemke
Copy link

dbemke commented Apr 24, 2024

Problem description

In one of forms in a project submissions aren’t numbered correctly. There are negative numbers in ordinal numbers of submissions. I tried to reproduce it by adding submissions or checking some other forms with many submissions but the URL below is the only example of the issue I could find so I don’t know what’s the factor causing it or how to reproduce it. The issue doesn’t occur e.g. in https://test.getodk.cloud/#/projects/436/forms/all-widgets/submissions
In Firefox I also noticed that the table isn't even.

URL of the page

https://test.getodk.cloud/#/projects/385/forms/all-widgets/submissions

Steps to reproduce the problem

  1. Open the URL with submissions ("URL of the page").
  2. Scroll down and check ordinal numbers of submissions

Screenshot

all385

Expected behavior

Ordinal numbers in submission should start from 1.

Central version shown in version.txt

https://test.getodk.cloud/
versions:
9a9ec7c (v2023.5.1-10-g9a9ec7c)
+c25bc15087ca045496d3bdbc806ca0752b955216 client (v2023.5.0-64-gc25bc150)
+cfe46c97e6e38d8e551ce253ba47d0b378d19352 server (v2023.5.0-56-gcfe46c97)

Browser

Chrome, Firefox

@matthew-white matthew-white added bug backend Requires a change to the API server needs testing Needs manual testing labels Apr 24, 2024
@matthew-white matthew-white self-assigned this Apr 24, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Apr 24, 2024
@matthew-white
Copy link
Member

This is likely the same issue as #608, though the example you identified is different from the two mentioned in that issue. We should have a fix for #608 soon, and once we do, we should check that all the examples have been fixed, both for that issue and for this one. We think the behavior described in this issue can happen when an instance ID is reused, for example, by two submissions in two different projects.

In Firefox I also noticed that the table isn't even.

This sounds like #607. Does that sound right?

@dbemke
Copy link
Author

dbemke commented Apr 25, 2024

This sounds like #607. Does that sound right?

Yes

@dbemke
Copy link
Author

dbemke commented Apr 25, 2024

While testing I thought about that issue one of our tests. We use ODK Briefcase to pull and push forms from/to Central. Can this duplicate instance IDs when I pull a form from one project and push it to a different project?

@dbemke
Copy link
Author

dbemke commented Apr 25, 2024

The form simple mention in 608 issue is a form that we was used to send 1000 instances copied to Collect and send to Central

@lognaturel
Copy link
Member

Can this duplicate instance IDs when I pull a form from one project and push it to a different project?

Yes, that's almost certainly what makes the bug appear. But the problem is the bug, not that you're making it appear! 😊

@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Apr 25, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Apr 26, 2024
@srujner
Copy link

srujner commented Apr 26, 2024

Tested with Success!

1 similar comment
@dbemke
Copy link
Author

dbemke commented Apr 26, 2024

Tested with Success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified bug
Projects
Status: ✅ done
Development

No branches or pull requests

4 participants