Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops: allow for multiple instances #214

Merged
merged 1 commit into from
May 18, 2021

Conversation

yanokwa
Copy link
Member

@yanokwa yanokwa commented Apr 20, 2021

The use of container_name means that you can't run multiple instances of Central on the same machine.

It also means you can't ever have a container called mail or service or secrets. Removing the container name solves this problem because Docker automatically prepends the folder name to the container (e.g., service becomes central_service_1). This happens with our PostgreSQL container already since it doesn't have a container_name.

  • I have confirmed that you can upgrade existing installs of Central with this change and it loads just fine.
  • I have confirmed that after upgrade, Enketo (which uses host-name based addressing) works by launching a preview. This is because Docker uses the service name to reach containers.
  • I have confirmed that I can run multiple copies of Central on the same machine and they both load.

This isn't a must have change, so if it feels high risk, I'm open to waiting until after v1.2

@yanokwa yanokwa force-pushed the multiple-instances branch from 152a0b5 to e34ccb9 Compare April 20, 2021 05:32
@yanokwa yanokwa marked this pull request as ready for review April 20, 2021 05:45
@yanokwa yanokwa requested a review from issa-tseng April 23, 2021 12:58
@issa-tseng
Copy link
Member

i think we might depend on these names in the docs?

@yanokwa
Copy link
Member Author

yanokwa commented Apr 24, 2021

@issa-tseng Good question. The docs seem to use docker-compose name and those are run in the folder where Central is installed, so you can still refer to the name (e.g., service, nginx).

@yanokwa yanokwa force-pushed the multiple-instances branch 2 times, most recently from 499d3d9 to bcf2654 Compare May 18, 2021 16:26
@yanokwa yanokwa force-pushed the multiple-instances branch from bcf2654 to 1e1ae07 Compare May 18, 2021 16:27
@matthew-white matthew-white merged commit db81a5f into getodk:master May 18, 2021
@yanokwa yanokwa deleted the multiple-instances branch November 18, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants