Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyxform to fix geojson support #750

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update pyxform to fix geojson support #750

merged 1 commit into from
Oct 10, 2024

Conversation

lognaturel
Copy link
Member

Closes #

What has been done to verify that this works as intended?

Made docker-compose change on dev, verified I can convert a form with geojson attachment.

Why is this the best possible solution? Were any other approaches considered?

This fix comes in Validate where we've added the jackson dependency back in. Ideally we would not need it but for now this fix brings back broken functionality.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should just fix geojson support. That's all that's changed across the stack.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@lognaturel lognaturel requested a review from sadiqkhoja October 9, 2024 21:19
@matthew-white
Copy link
Member

Is it OK to ship everything on the next branch with the patch release? I think so, but just wanted to check. If so, I'll retitle the PR for the next branch so that it's clear that it's for the patch.

@lognaturel
Copy link
Member Author

Yes and thank you!

Copy link
Contributor

@sadiqkhoja sadiqkhoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated locally, Forms with external geojson files can be uploaded.

@lognaturel lognaturel merged commit 79792be into next Oct 10, 2024
3 checks passed
@lognaturel lognaturel deleted the pyxform-geojson branch October 10, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants