Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jr:itext not resolving correctly as param for external app (and possibly elsewhere) #5116

Closed
lognaturel opened this issue Apr 20, 2022 · 3 comments
Assignees

Comments

@lognaturel
Copy link
Member

Software and hardware versions

Collect v2022.1

Problem description

device-2022-04-20-115109

Steps to reproduce the problem

Fill out the second question on this form

Expected behavior

The translated form name and label should be passed on.

Other information

I've reproduced this in v2022.1 so it's not entirely recent.

I haven't tried using jr:itext in any other context or looked at what kinds of JavaRosa test coverage there is. That might be my next step.

@lognaturel
Copy link
Member Author

This doesn't look like it has to be in the hotfix to me but it would be good to do a little bit more exploration to confirm there isn't a deeper problem.

@grzesiek2010 grzesiek2010 self-assigned this Apr 21, 2022
@grzesiek2010
Copy link
Member

This is not a bug in Collect. The generated form contained wrong root node names (data instead of counter) in paths: jr:itext('/data/counter2:label') instead of jr:itext('/counter/counter2:label'). The problem was caused by not specified name in settings: https://xlsform.org/en/#specify-xforms-root-node-name which I fixed in getodk/counter#21. it worked well in XLSForm Online v1.x (based on a file name I guess) but if you use XLSForm Online v2.x it is required.

@lognaturel
Copy link
Member Author

Oh, wonderful. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants