Fix forms not being deletable

[seadowg]

Closes #6338

Why is this the best possible solution? Were any other approaches considered?

Not a lot to discuss! The problem was just that Instance objects created via Instance.Builder had the wrong default value.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This should just fix the issue. It'll be good to check that forms can be deleted when expected.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• added any new strings with date formatting to DateFormatsTest
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[grzesiek2010]

We have that test whenFormHasCreatedEntity_doesNotAppearInListToDelete:

1. Please clarify what created entity means. You can add a comment or change the test name to make it clear that it takes place on finalizing.
2. I think it would be good to have a test in the same class where we just save a form as a draft and test if it can be deleted.

[seadowg]

I think it would be good to have a test in the same class where we just save a form as a draft and test if it can be deleted.

I'd thought about that (I actually wrote that test then deleted it), but I realized we already had a test for finalized forms and felt like adding this unit test was simpler than testing all the possible states that saved forms could be in.

[grzesiek2010]

Is it handled correctly when forms are synced from disk and should be finalized?

[seadowg]

Do you mean if a form has an entity? We don't currently support local entity creation/updates for synced instances. Otherwise, every Instance should now be deletable.

[WKobus]

Sent instances of forms that create or update entity still can't be deleted, those instances do not appear in delete form - saved forms.
Sent instances of non entity forms work correctly and those appear in saved forms - delete forms.
@seadowg

[seadowg]

Sent instances of forms that create or update entity still can't be deleted, those instances do not appear in delete form - saved forms.
Sent instances of non entity forms work correctly and those appear in saved forms - delete forms.

Could you file an issue? As far as I can tell, we should be OK to delete sent forms that create/update entities. We can discuss over at the issue though.

[WKobus]

Tested with Success

Verified on device with Android 14

Verified cases:

• Deleting drafts, finalized and sent instances of forms that create or update entity
• Deleting drafts, finalized and sent instances of non entity forms
• Forms with auto delete

[dbemke]

Tested with Success

Verified on device with Android 10