Implemented #sanitizedCanonicalPath method #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
reviewed
Sep 9, 2024
|
|
||
| if (canonicalPath.contains(androidDataSegment, true)) { | ||
| val regex = Regex(androidDataSegment, RegexOption.IGNORE_CASE) | ||
| return canonicalPath.replace(regex, androidDataSegment) |
There was a problem hiding this comment.
I think you should be able to do the replace without a contains check -- if there's no match it just won't be replaced.
lognaturel
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #6364
Why is this the best possible solution? Were any other approaches considered?
As discussed in the issue, the goal of this PR is to determine whether other parts of the path can also change after calling
File.getCanonicalPath, or if it's always the/Android/data/part. Once we have the answer, we can implement the final solution.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think it doesn't require testing. Once carefully reviewed it can be merged.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest