Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glEsVersion from manifest #6414

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Sep 13, 2024

Closes #6410

Why is this the best possible solution? Were any other approaches considered?

The previous approach implemented in #6411 does to seem to work so let's try to remove glEsVersion from the manifest file at all.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 mentioned this pull request Sep 13, 2024
6 tasks
@lognaturel lognaturel changed the title Remove glEsVersion from manifest at all Remove glEsVersion from manifest Sep 13, 2024
Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that this works with the Play Store! 🎉 And I think it better captures our intent -- you don't need OpenGL to use Collect and we have runtime checks for the features that do need it.

@lognaturel lognaturel merged commit 66e9c1f into getodk:master Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't require OpenGL 3.0
2 participants