Disable StrictMode for FormHiearchyActivity #6456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
requested changes
Oct 16, 2024
collect_app/src/main/java/org/odk/collect/android/formhierarchy/FormHierarchyActivity.java
Outdated
Show resolved
Hide resolved
| protected void onDestroy() { | ||
| super.onDestroy(); | ||
|
|
||
| CollectStrictMode.enable(); |
There was a problem hiding this comment.
Is this a temporary solution? If so should we file an issue to fix it in the future?
There was a problem hiding this comment.
I've added an issue: #6470
grzesiek2010
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6397
Why is this the best possible solution? Were any other approaches considered?
While working on this, I discovered that we'd accidentally disabled StrictMode protection for
DatabaseEntitiesRepository. Fortunately, it doesn't seem like we'd added any violations as I was able to add it back in without problems (other than the expected ones).I'd initially thought about removing the blanket protection on the whole repository and just adding custom slow calls to some methods, but I realised I'd have to remove protection on pretty much all the
get...methods to allow for different kinds of filters in the hierarchy.Instead, I've gone for an approach where StrictMode is disabled when the
FormHierarchyActivityis created and then re-enabled when it is destroyed. This means we get full protection elsewhere, and only the "broken" code will have to change when we fix it.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Shouldn't affect users at all as the crashes/errors were only visible in debug. No need for testing here.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest