Fix leaking form session when viewing submission #6497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6483
Memory usage when filling a form and then viewing the submission several times before the change:
...and after:
For some reason the axis on the left side makes the memory usage look pretty similar, but you can see from the "Total" number that that's not the case.
Why is this the best possible solution? Were any other approaches considered?
We'll want to solidify a fix with #5420, but this should provide a band-aid for the moment which hopefully prevents many OOMs in the wild.
I haven't written a test for this due to the fix being temporary and that it's hard to test the actual intention here.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The only area of the app affected is viewing submissions.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest