Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaking form session when viewing submission #6497

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Nov 5, 2024

Closes #6483

Memory usage when filling a form and then viewing the submission several times before the change:

Screenshot 2024-11-05 at 14 31 42

...and after:

Screenshot 2024-11-05 at 14 34 06

For some reason the axis on the left side makes the memory usage look pretty similar, but you can see from the "Total" number that that's not the case.

Why is this the best possible solution? Were any other approaches considered?

We'll want to solidify a fix with #5420, but this should provide a band-aid for the moment which hopefully prevents many OOMs in the wild.

I haven't written a test for this due to the fix being temporary and that it's hard to test the actual intention here.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The only area of the app affected is viewing submissions.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review November 5, 2024 15:00
@seadowg seadowg requested a review from grzesiek2010 November 5, 2024 15:00
@lognaturel lognaturel added the high priority Should be looked at before other PRs/issues label Nov 5, 2024
@grzesiek2010 grzesiek2010 merged commit 8a26bf8 into getodk:master Nov 5, 2024
6 checks passed
@seadowg seadowg deleted the view-only-leak branch November 5, 2024 20:46
@dbemke
Copy link

dbemke commented Nov 6, 2024

Tested with Success!

Verified on a device with Android 10

Verified cases:

  • opening big finalized form and drafts

@WKobus
Copy link

WKobus commented Nov 6, 2024

Tested with Success!

Verified on a device with Android 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak when viewing saved form
5 participants