Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove education dialog for error pills in Drafts list #6528

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lognaturel
Copy link
Member

Why is this the best possible solution? Were any other approaches considered?

Error/no errors pills were introduced in Oct 2023. It's fairly common for data collectors to switch devices or otherwise need to reinstall Collect. Seeing the education message again is not a very big deal but it is slightly annoying so I think now is a good time to remove it.

Happy to discuss and close this if others see a good reason to keep it in longer.

I considered keeping the "New feature" string but that would require using it somewhere to pass lint and I don't think it's worth it. I can bring back the translations if we need it again.

I used the translation editor to remove the string definition from all languages. This left the comments behind and those will be cleaned up the next time we update from Transifex.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The intentional change is to remove the information dialog. I think there is a low risk of a bug. The biggest risk is probably that someone who hasn't yet seen the pills doesn't see the information dialog and is confused about their function. I think they're pretty self-explanatory so this feels unlikely to me.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@alyblenkin
Copy link
Collaborator

Given we've had the educational dialog for quite some time, I think it's safe to remove it. Mostly because the pills are pretty intuitive and we haven't heard any feedback, that I'm aware of, about them causing confusion for data collectors.

Copy link
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that this is having the same problem as #6526.

Copy link
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connected tests aren't compiling. Looks like there's at least one constructor call (in InstancePickActionTest) that needs updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants