Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common CC flow with different 3DS flows [airwallex,stripe] #70

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Common CC flow with different 3DS flows [airwallex,stripe] #70

merged 8 commits into from
Nov 27, 2024

Conversation

zeyarpaing
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

Found changes in packages/** but the version numbers remained the same.\n We ideally want to increment the version numbers when making changes to the packages.\n\n@zeyarpaing, please consider bumping the version of the following packages:
- packages/vanilla: Current version in main: 0.1.5
- packages/react: Current version in main: 0.1.5

syvlabs
syvlabs requested changes Nov 26, 2024
View reviewed changes
packages/utils/src/cde-client.ts Outdated Show resolved Hide resolved
packages/utils/src/cde-client.ts Outdated Show resolved Hide resolved
packages/utils/src/flows/card/common-cc-flow.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Found changes in packages/** but the version numbers remained the same.\n We ideally want to increment the version numbers when making changes to the packages.\n\n@zeyarpaing, please consider bumping the version of the following packages:
- packages/vanilla: Current version in main: 0.1.5
- packages/react: Current version in main: 0.1.5

syvlabs
syvlabs requested changes Nov 26, 2024
View reviewed changes
packages/utils/src/base-url.ts Outdated

export const getCdeBaseUrl = () => {
// @ts-expect-error ojs is not defined in the global scope
return new URL(window?.ojs?.config?.baseUrl ?? FRAME_BASE_URL).origin;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use window.ojs because it's supposed to be for debugging purposes only. We want to minimize use of global variables because it leads to spaghetti. Instead please pass baseUrl through OjsContext, which is the more appropriate route for it. runOjsFlows have access to the context

@github-actions GitHub Actions
Copy link

Found changes in packages/** but the version numbers remained the same.\n We ideally want to increment the version numbers when making changes to the packages.\n\n@zeyarpaing, please consider bumping the version of the following packages:
- packages/vanilla: Current version in main: 0.1.5
- packages/react: Current version in main: 0.1.5

@github-actions GitHub Actions
Copy link

Found changes in packages/** but the version numbers remained the same.\n We ideally want to increment the version numbers when making changes to the packages.\n\n@zeyarpaing, please consider bumping the version of the following packages:
- packages/vanilla: Current version in main: 0.1.5
- packages/react: Current version in main: 0.1.5

@zeyarpaing zeyarpaing merged commit 7c15e03 into main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syvlabs syvlabs syvlabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeyarpaing @syvlabs @jareddantis