From 09c5bfaa4576f5e4eb512e6b2bed785813f5a222 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Tom=C3=A1nek?= Date: Fri, 29 Mar 2024 19:32:35 +0100 Subject: [PATCH] feat: send appName as an identifier in LD context (#461) --------- Co-authored-by: Mark Lee --- ...-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot | 1 + ...-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot | 1 + ...-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot | 1 + ...-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot | 1 + ...-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot | 1 + templates/deployments/appname/app.jsonnet.tpl | 1 + 6 files changed, 6 insertions(+) diff --git a/templates/.snapshots/TestRenderDeploymentJsonnet-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot b/templates/.snapshots/TestRenderDeploymentJsonnet-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot index aec2f7aa..9b51f292 100644 --- a/templates/.snapshots/TestRenderDeploymentJsonnet-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot +++ b/templates/.snapshots/TestRenderDeploymentJsonnet-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot @@ -103,6 +103,7 @@ local all = { Path: '/run/secrets/outreach.io/launchdarkly/sdk-key', }, flagsToAdd: { + appName: app.name, bento: app.bento, channel: if isDev then 'dev' else app.channel, } + if isDev then { diff --git a/templates/.snapshots/TestRenderDeploymentJsonnetWithHPA-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot b/templates/.snapshots/TestRenderDeploymentJsonnetWithHPA-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot index 0dee3241..b32090eb 100644 --- a/templates/.snapshots/TestRenderDeploymentJsonnetWithHPA-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot +++ b/templates/.snapshots/TestRenderDeploymentJsonnetWithHPA-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot @@ -103,6 +103,7 @@ local all = { Path: '/run/secrets/outreach.io/launchdarkly/sdk-key', }, flagsToAdd: { + appName: app.name, bento: app.bento, channel: if isDev then 'dev' else app.channel, } + if isDev then { diff --git a/templates/.snapshots/TestRenderDeploymentJsonnet_Canary-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot b/templates/.snapshots/TestRenderDeploymentJsonnet_Canary-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot index a9aa10e9..692eed0d 100644 --- a/templates/.snapshots/TestRenderDeploymentJsonnet_Canary-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot +++ b/templates/.snapshots/TestRenderDeploymentJsonnet_Canary-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot @@ -138,6 +138,7 @@ local all = { Path: '/run/secrets/outreach.io/launchdarkly/sdk-key', }, flagsToAdd: { + appName: app.name, bento: app.bento, channel: if isDev then 'dev' else app.channel, } + if isDev then { diff --git a/templates/.snapshots/TestRenderDeploymentJsonnet_Canary_emptyServiceActivities-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot b/templates/.snapshots/TestRenderDeploymentJsonnet_Canary_emptyServiceActivities-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot index 42a67246..5670f4ad 100644 --- a/templates/.snapshots/TestRenderDeploymentJsonnet_Canary_emptyServiceActivities-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot +++ b/templates/.snapshots/TestRenderDeploymentJsonnet_Canary_emptyServiceActivities-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot @@ -110,6 +110,7 @@ local all = { Path: '/run/secrets/outreach.io/launchdarkly/sdk-key', }, flagsToAdd: { + appName: app.name, bento: app.bento, channel: if isDev then 'dev' else app.channel, } + if isDev then { diff --git a/templates/.snapshots/TestUseKIAMFalse-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot b/templates/.snapshots/TestUseKIAMFalse-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot index c46d6d2c..e9c1fa4c 100644 --- a/templates/.snapshots/TestUseKIAMFalse-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot +++ b/templates/.snapshots/TestUseKIAMFalse-deployments-appname-app.jsonnet.tpl-deployments-testing-testing.jsonnet.snapshot @@ -105,6 +105,7 @@ local all = { Path: '/run/secrets/outreach.io/launchdarkly/sdk-key', }, flagsToAdd: { + appName: app.name, bento: app.bento, channel: if isDev then 'dev' else app.channel, } + if isDev then { diff --git a/templates/deployments/appname/app.jsonnet.tpl b/templates/deployments/appname/app.jsonnet.tpl index 68c8b6c2..e152d6e6 100644 --- a/templates/deployments/appname/app.jsonnet.tpl +++ b/templates/deployments/appname/app.jsonnet.tpl @@ -169,6 +169,7 @@ local all = { Path: '/run/secrets/outreach.io/launchdarkly/sdk-key', }, flagsToAdd: { + appName: app.name, bento: app.bento, channel: if isDev then 'dev' else app.channel, } + if isDev then {