From 981709fed02df02d7fcc3c3680ab2add48aeef76 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Mon, 6 May 2024 14:01:51 -0700 Subject: [PATCH] fix: upgrade `@getoutreach/eslint-config` to 2.0.0 (#497) --- ...ot.yml.tpl-.github-dependabot.yml.snapshot | 2 -- templates/_helpers.tpl | 18 +++++++--------- templates/api/clients/node/.eslintrc.js.tpl | 21 +------------------ 3 files changed, 8 insertions(+), 33 deletions(-) diff --git a/templates/.snapshots/TestRenderDependabot-.github-dependabot.yml.tpl-.github-dependabot.yml.snapshot b/templates/.snapshots/TestRenderDependabot-.github-dependabot.yml.tpl-.github-dependabot.yml.snapshot index a9b4208..8c3388f 100644 --- a/templates/.snapshots/TestRenderDependabot-.github-dependabot.yml.tpl-.github-dependabot.yml.snapshot +++ b/templates/.snapshots/TestRenderDependabot-.github-dependabot.yml.tpl-.github-dependabot.yml.snapshot @@ -41,10 +41,8 @@ updates: - dependency-name: "@typescript-eslint/eslint-plugin" - dependency-name: "@typescript-eslint/parser" - dependency-name: "eslint" - - dependency-name: "eslint-config-prettier" - dependency-name: "eslint-plugin-jest" - dependency-name: "eslint-plugin-jsdoc" - - dependency-name: "eslint-plugin-lodash" - dependency-name: "eslint-plugin-node" - dependency-name: "grpc-tools" - dependency-name: "grpc_tools_node_protoc_ts" diff --git a/templates/_helpers.tpl b/templates/_helpers.tpl index 4756cf2..7f6499d 100644 --- a/templates/_helpers.tpl +++ b/templates/_helpers.tpl @@ -175,23 +175,19 @@ nodejs: {{- end }} devDependencies: - name: "@getoutreach/eslint-config" - version: ^1.0.4 + version: ^2.0.0 - name: "@types/jest" version: ^26.0.15 - name: "@typescript-eslint/eslint-plugin" - version: ^2.33.0 + version: ^7.8.0 - name: "@typescript-eslint/parser" - version: ^2.33.0 + version: ^7.8.0 - name: eslint - version: ^7.13.0 - - name: eslint-config-prettier - version: ^6.15.0 + version: ^8.57.0 - name: eslint-plugin-jest - version: ^24.1.3 + version: ^28.3.0 - name: eslint-plugin-jsdoc - version: ^30.7.7 - - name: eslint-plugin-lodash - version: ^7.1.0 + version: ^48.2.3 - name: eslint-plugin-node version: ^11.1.0 - name: grpc-tools @@ -213,7 +209,7 @@ nodejs: - name: tsconfig-paths version: ^3.9.0 - name: typescript - version: ^4.0.5 + version: ^4.9.5 {{- range stencil.GetModuleHook "js_modules_dev" }} - name: {{ .name }} version: {{ .version }} diff --git a/templates/api/clients/node/.eslintrc.js.tpl b/templates/api/clients/node/.eslintrc.js.tpl index 3bf672a..cf1fd27 100644 --- a/templates/api/clients/node/.eslintrc.js.tpl +++ b/templates/api/clients/node/.eslintrc.js.tpl @@ -1,23 +1,4 @@ {{- $_ := stencil.ApplyTemplate "skipGrpcClient" "node" }} module.exports = { - extends: ['@getoutreach/eslint-config/node', 'plugin:jsdoc/recommended'], - plugins: ['jsdoc', '@typescript-eslint'], - ignorePatterns: ['*.d.ts', 'publish.js'], - rules: { - 'node/no-unsupported-features/es-syntax': 'off', // Typescript syntax uses unsupported features in node v10 - 'node/no-missing-import': 'off', // The import detection doesn't seem to work with TS and node v10 - - // JSDoc rules - // The param type is redundant with the typescript specified type so is disabled - 'jsdoc/require-param-type': 0, - 'jsdoc/require-returns-type': 0 - }, - parser: '@typescript-eslint/parser', - parserOptions: { - ecmaVersion: 6, - sourceType: 'module', - ecmaFeatures: { - modules: true - } - } + extends: ['@getoutreach/eslint-config/node'], };