Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goreleaser): fix env block #436

Merged
merged 2 commits into from
Feb 26, 2024
Merged

fix(goreleaser): fix env block #436

merged 2 commits into from
Feb 26, 2024

Conversation

yj-yan
Copy link
Contributor

@yj-yan yj-yan commented Feb 26, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

This is to fix the goreleaser format in some repos. With ## for commenting out, the auto formatting breaks the syntax and run into error when restencil. Spotted tested in rms gearbox orc and localizer.

Jira ID

DT-4258

Notes for your reviewers

@yj-yan yj-yan requested a review from a team as a code owner February 26, 2024 22:45
Copy link

swarmia bot commented Feb 26, 2024

@yj-yan yj-yan enabled auto-merge (squash) February 26, 2024 22:50
@yj-yan yj-yan merged commit f6304a5 into main Feb 26, 2024
2 checks passed
@yj-yan yj-yan deleted the yjyan/env-block branch February 26, 2024 22:53
pbr0ck3r added a commit that referenced this pull request Mar 1, 2024
* fix(deployments): remove unused import (#433)

`mixins/accounts.env.jsonnet` doesn't seem to exist anymore and it's not referenced anywhere in this file.

* feat(manifest): upgrade Go version to 1.22.0 (#435)

* fix(goreleaser): fix env block (#436)

* fix(goreleaser): fix env block

* fix: update test snapshot

---------

Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Yujie Yan <134322381+yj-yan@users.noreply.github.com>
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.20.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.19.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants