feat: change the PDB maxUnavailable to 10% #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdenekvicar
approved these changes
Mar 18, 2024
jan-ludvik
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Thank you! This came from my request as bigger apps with dozens of replicas still allow only 1 replica to be disrupted and that is slowing down our autoscaling significantly.
For example lightning app has 60 replicas so this change will mean 6 will be possible to disrupt at a time which should open more options for cluster consolidation process.
pbr0ck3r
approved these changes
Mar 25, 2024
|
🎉 This PR is included in version 1.22.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
Change the maxUnavailable to 10% to reduce extra cost when draining nodes.
Feature request: https://outreach-hq.slack.com/archives/C01CAR6GVPD/p1710492579539699
Jira ID
[XX-XX]
Notes for your reviewers