Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PDB maxUnavailable value needs to be a string #459

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

yj-yan
Copy link
Contributor

@yj-yan yj-yan commented Mar 27, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

On the tin.

Jira ID

[XX-XX]

Notes for your reviewers

@yj-yan yj-yan requested a review from a team as a code owner March 27, 2024 20:30
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think jsonnetfmt might standardize to single quotes.

@yj-yan
Copy link
Contributor Author

yj-yan commented Mar 27, 2024

I think jsonnetfmt might standardize to single quotes.

That's right, updated.

@yj-yan yj-yan requested a review from malept March 27, 2024 20:56
@yj-yan yj-yan merged commit 3b9500a into main Mar 27, 2024
3 checks passed
@yj-yan yj-yan deleted the yjyan/fix/maxUnavailable-string branch March 27, 2024 21:07
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.22.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants