feat: send appName as an identifier in LD context #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
changed the title
malept
requested changes
Mar 28, 2024
malept
approved these changes
Mar 29, 2024
|
🎉 This PR is included in version 1.22.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Update LaunchDarkly context by introducing
appNameproperty in the user context. This property is already used by client-side SDK (OrCA) to identify various apps built in OrCA. In order to have a better overview of usage of flags across our codebase, we're introducing theappNameproperty across all LD clients.This is a backwards compatible change because it doesn't change how existing flags are evaluated. It's not expected to use this new property in feature flag targeting; instead, this will come in handy as a debugging/organization tool.
Recently, there were at least two occasions where this would have been useful:
In both cases, having the
appNamewould speed up the fault detection.Jira ID
[XX-XX]
Notes for your reviewers