Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goreleaser): correct the name of env block and indents #489

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

yj-yan
Copy link
Contributor

@yj-yan yj-yan commented Apr 19, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

It turns out if the cli name contains special character "-", it will breaks the stencil block. Use the index to name the block instead. Also fixed the indent of this file.

Jira ID

[XX-XX]

Notes for your reviewers

@yj-yan yj-yan requested a review from a team as a code owner April 19, 2024 00:06
@yj-yan yj-yan marked this pull request as draft April 19, 2024 00:22
@yj-yan yj-yan marked this pull request as ready for review April 19, 2024 22:09
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using index to differentiate blocks is going to make it confusing for users. Can we instead sanitize the CLI name when using it as the block name?

@yj-yan yj-yan requested a review from malept April 24, 2024 17:18
@yj-yan yj-yan requested a review from malept April 24, 2024 19:21
@yj-yan yj-yan enabled auto-merge (squash) April 24, 2024 20:14
@yj-yan yj-yan merged commit 6b7d17b into main Apr 24, 2024
2 checks passed
@yj-yan yj-yan deleted the yjyan/fix-env-block branch April 24, 2024 20:17
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.0-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants