-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(goreleaser): correct the name of env block and indents #489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using index to differentiate blocks is going to make it confusing for users. Can we instead sanitize the CLI name when using it as the block name?
🎉 This PR is included in version 1.23.0-rc.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
It turns out if the cli name contains special character "-", it will breaks the stencil block. Use the index to name the block instead. Also fixed the indent of this file.
Jira ID
[XX-XX]
Notes for your reviewers