Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): remove unused wait-on devDependency #493

Merged
merged 2 commits into from
May 2, 2024

Conversation

malept
Copy link
Member

@malept malept commented Apr 29, 2024

What this PR does / why we need it

As far as I can tell, wait-on has never been used in the entire history of the Node.js gRPC client :rage4:

Jira ID

DT-4345

Copy link

swarmia bot commented Apr 29, 2024

@malept
Copy link
Member Author

malept commented Apr 29, 2024

Blocked by #494

@malept malept force-pushed the malept/dt-4345/fix/remove-wait-on-devdep branch from e879420 to a4bcdf8 Compare April 29, 2024 22:46
@malept malept marked this pull request as ready for review April 29, 2024 23:37
@malept malept requested a review from a team as a code owner April 29, 2024 23:37
@malept malept force-pushed the malept/dt-4345/fix/remove-wait-on-devdep branch from a4bcdf8 to 0655396 Compare May 1, 2024 16:52
@malept malept enabled auto-merge (squash) May 1, 2024 16:52
@malept malept merged commit 435c747 into main May 2, 2024
2 checks passed
@malept malept deleted the malept/dt-4345/fix/remove-wait-on-devdep branch May 2, 2024 17:15
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.0-rc.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants