Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stencil): enable weekly RC releases #495

Merged
merged 1 commit into from
May 1, 2024
Merged

fix(stencil): enable weekly RC releases #495

merged 1 commit into from
May 1, 2024

Conversation

pbr0ck3r
Copy link
Contributor

@pbr0ck3r pbr0ck3r commented May 1, 2024 •
edited

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

  • restencil

Jira ID

https://outreach-io.atlassian.net/browse/DT-4349

Notes for your reviewers

@pbr0ck3r pbr0ck3r requested a review from a team as a code owner May 1, 2024 20:17
malept
malept requested changes May 1, 2024
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to set this value in service.yaml and restencil:

https://github.com/getoutreach/stencil-circleci/blob/972111352fff7723164358b5219eff964e482ab8/manifest.yaml#L32

.circleci/config.yml Outdated Show resolved Hide resolved
@pbr0ck3r
Copy link
Contributor Author

pbr0ck3r commented May 1, 2024

I think you need to set this value in service.yaml and restencil:

https://github.com/getoutreach/stencil-circleci/blob/972111352fff7723164358b5219eff964e482ab8/manifest.yaml#L32

enablePrereleases is set to true already

@yj-yan
Copy link
Contributor

yj-yan commented May 1, 2024 •
edited

A few more changes are needed in service.yaml:

  • SetprereleasesBranch: main.
  • Set autoPrereleases: true to allow auto RC release.
  • Use rc channel for devbase and stencil-circleci.

@pbr0ck3r pbr0ck3r requested a review from malept May 1, 2024 20:45
@malept
Copy link
Member

malept commented May 1, 2024

A few more changes are needed in service.yaml:

* Set`prereleasesBranch: main`.

* Set `autoPrereleases: true` to allow auto RC release.

* Use `rc` channel for `devbase` and `stencil-circleci`.

These instructions should go in the Jira issue.

malept
malept reviewed May 1, 2024
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Yujie's instructions, stencil-circleci needs to be in RC

@pbr0ck3r pbr0ck3r requested a review from malept May 1, 2024 21:03
@pbr0ck3r pbr0ck3r changed the title fix: re-stencil fix(stencil): enable weekly RC releases May 1, 2024
@pbr0ck3r pbr0ck3r merged commit 29fbb5a into main May 1, 2024
2 checks passed
@pbr0ck3r pbr0ck3r deleted the pbr0ck3r/fix/re-stencil branch May 1, 2024 21:12
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.0-rc.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
released on @main released
Projects
None yet
Milestone
No milestone
3 participants
@pbr0ck3r @yj-yan @malept