Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goreleaser): replace block name containing underscore #511

Merged
merged 2 commits into from
May 23, 2024

Conversation

yj-yan
Copy link
Contributor

@yj-yan yj-yan commented May 23, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

Fixes the block name error when there is underscore in the command.

Jira ID

DT-4393

Notes for your reviewers

@yj-yan yj-yan requested a review from a team as a code owner May 23, 2024 17:40
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine except that the code could probably be simplified.

templates/.goreleaser.yml.tpl Outdated Show resolved Hide resolved
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
@yj-yan
Copy link
Contributor Author

yj-yan commented May 23, 2024

This seems fine except that the code could probably be simplified.

Thanks! It is nice to do it in one line.

@yj-yan yj-yan requested a review from malept May 23, 2024 18:15
@yj-yan yj-yan merged commit ecaf59e into main May 23, 2024
3 checks passed
@yj-yan yj-yan deleted the yjyan/replace-underscore branch May 23, 2024 18:24
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants