Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomod): add toolchain directive #516

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

malept
Copy link
Member

@malept malept commented Jun 21, 2024

What this PR does / why we need it

This should ensure that the Go version specified by the manifest is the same version as the toolchain used.

This should ensure that the Go version specified by the manifest is the same version as the toolchain used.
@malept malept requested a review from a team as a code owner June 21, 2024 17:03
Copy link
Contributor

@yj-yan yj-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to update the test snapshots.

@malept
Copy link
Member Author

malept commented Jun 21, 2024

Looks good, just need to update the test snapshots.

This is what happens when I update a repo with the GitHub UI 😆 😢

@malept malept merged commit d2ec06b into main Jun 21, 2024
3 checks passed
@malept malept deleted the malept/fix/gomod-toolchain branch June 21, 2024 17:15
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.23.2-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-1
Copy link
Contributor

🎉 This PR is included in version 1.23.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants