Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate configuration strategy #8

Open
carolynvs opened this issue Feb 5, 2020 · 0 comments
Open

Investigate configuration strategy #8

carolynvs opened this issue Feb 5, 2020 · 0 comments
Labels
enhancement New feature or request hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please.

Comments

@carolynvs
Copy link
Member

Right now we have multiple ways to configure the plugin:

  • Use the default storage connection string env var for blob storage
  • Specify an alt storage connection string env var
  • Use the default service principal env vars for key vault
  • Specify a prefix to apply to the the service principal env vars

And looming in the wings is being able to log in with az login (MSI) which I have partway implemented.

Investigate if we can bring this down a bit so that there aren't so many ways to do this, it's confusing to have one way to auth for storage and another for everything else.

See #6 (comment), as part of this let's try to cleanup the config struct if we can as well.

@carolynvs carolynvs self-assigned this Feb 5, 2020
@carolynvs carolynvs removed their assignment Feb 25, 2022
@carolynvs carolynvs added enhancement New feature or request hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. labels Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please.
Projects
None yet
Development

No branches or pull requests

1 participant