Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make (mage) targets for controller-gen and kustomize #243

Open
2 tasks
troy0820 opened this issue Aug 7, 2023 · 2 comments
Open
2 tasks

Add make (mage) targets for controller-gen and kustomize #243

troy0820 opened this issue Aug 7, 2023 · 2 comments
Assignees
Labels
self care 💅🏽 Tasks that help keep Porter running smoothly tech debt 💸

Comments

@troy0820
Copy link
Member

troy0820 commented Aug 7, 2023

Is your feature request related to a problem? Please describe.

Make targets that come bundle with kubebuilder/operator-framework allow the crds/manifests to be generated when changes are made to the crds, etc. Having this as mage targets will allow the pipeline to vet that the crds matches what is described in the api/v1 layer.

Describe the solution you'd like

  • Include the kubebuilder make targets as mage targets to vet manifests created by the controller-gen/kustomize tool
  • Included mage targets in the pipeline

Describe alternatives you've considered
This used to be in the repo but was removed for some reason

Additional context
None

@troy0820 troy0820 self-assigned this Aug 7, 2023
@troy0820 troy0820 added self care 💅🏽 Tasks that help keep Porter running smoothly tech debt 💸 labels Aug 7, 2023
@troy0820
Copy link
Member Author

troy0820 commented Aug 8, 2023

potential targets:

  • make tools:
    • controller-gen tool install edit: may need updating to v0.12.1
    • kustomize tool install
  • make manifests - generates crds from api/v1
  • make install - generates crds from api/v1 and puts them on a cluster (installs crds, good for integration tests?)
  • make generate - generate deepcopy for api types (verify in pipeline)
    • controller-gen object paths=./api/v1

@troy0820
Copy link
Member Author

controller-gen is there EnsureControllerGen()
kustomize is there EnsureKustomize()

  • make generate needs to include the go generate to include the mocks in a PR that will help with testing the GRPCClient without the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self care 💅🏽 Tasks that help keep Porter running smoothly tech debt 💸
Projects
None yet
Development

No branches or pull requests

1 participant