-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete temporary resources when agent completes #54
Comments
It would be nice to have some configuration options:
|
We could use the built-in cleanup offered in k8s (https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/), but it will delete the resource based on the configured TTL when the job finishes(the job status is completed or failed). |
The plan is to add Resources created by the operator
Resources created by the agent (k8s driver)
I have created cnabio/cnab-go#300 to track supporting owner references in the k8s driver |
I chose to not go with the operator framework pruning library because it would be on us to schedule and call it regularly. There aren't any documented best practices on how to run that in an operator at this time and I didn't find any use of the library in existing projects to look for ideas. The simplicity of pawning off the pruning trigger onto k8s instead seems more reliable to me. |
When the agent completes, delete any temporary resources created by the operator such as: jobs, pvcs, secrets.
The text was updated successfully, but these errors were encountered: