Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch-all netlify redirects causes all 404 to be redirected to github. #2936

Open
ludfjig opened this issue Sep 29, 2023 · 0 comments
Open
Labels
bug Oops, sorry!

Comments

@ludfjig
Copy link
Contributor

ludfjig commented Sep 29, 2023

Describe the bug

The /:version/* https://github.com/getporter/porter/releases/download/:version/:splat 302 redirect rule in our netlify _redirects file causes all web requests that would have been a 404 on our site, to instead be a 404 on github. This is annoying because there's no easy way to get back to the porter website from the github 404.

However, this redirection is used in our install.sh scripts, and are curled to download porter. So we cannot remove it without also changing our install script.

Ideally, we would just make the redirection less general, to only match something of the format "vX.Y.Z", but that seems impossible with netlify redirection syntax.

To Reproduce

go to any website that doesn't exist, and you'll be redirected to github instead, e.g https://getporter.org/idontexist

Expected behavior

We should get shown the porter 404 page, not the github one.

@ludfjig ludfjig added the bug Oops, sorry! label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oops, sorry!
Projects
None yet
Development

No branches or pull requests

1 participant