Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from staticcheck to golangci-lint #3048

Closed
Tracked by #3113
dgannon991 opened this issue Mar 29, 2024 · 0 comments · Fixed by #3057
Closed
Tracked by #3113

Change from staticcheck to golangci-lint #3048

dgannon991 opened this issue Mar 29, 2024 · 0 comments · Fixed by #3057
Assignees

Comments

@dgannon991
Copy link
Member

What design is being proposed?
A change of linting tool to hopefully provide better code analysis, as staticcheck seems a bit basic in comparison to other go tools.

Risks/Concerns
There are 54 errors reported by golangci lint in the current main branch, these will require fixing before the check can be enforced.

Implementation details
Swap out the call in the magefile and then fix the linting errors. If you're happy with this, I'll gladly take a stab at it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants