Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying version of mixin in porter.yaml #3136

Open
KurtSchenk opened this issue May 30, 2024 · 1 comment
Open

Specifying version of mixin in porter.yaml #3136

KurtSchenk opened this issue May 30, 2024 · 1 comment
Labels
suggestion Idea for maintainers to consider. Do not take this issue until triaged.

Comments

@KurtSchenk
Copy link

Is your feature request related to a problem? Please describe.
Porter has mixins which are similar to plugins or packages that are listed in the porter.yaml file. However, the specific version of the mixin to install can only be provided in the Porter command. As a developer who has experience working with npm, NuGet modules, I find this limitation to be problematic.

Describe the solution you'd like
It would be more efficient to track mixin versions in the yaml file, as it is done in files like package.json and csproj, especially when it comes to debugging and dealing with broken CI. When it is in the porter.yaml, you can be sure the right version of the mixin matches what you have tested: the package behaves the same all through the development and deployment lifecycle.

Describe alternatives you've considered
N/A

Additional context
N/A

@KurtSchenk KurtSchenk added the suggestion Idea for maintainers to consider. Do not take this issue until triaged. label May 30, 2024
@schristoff
Copy link
Member

Hey!
To add clarification for future me and the community: Right now Mixins allow for clientVersion which is the version of the tool we download in the mixin. Ex: In the Terraform Mixin if we set ClientVersion to 1.1.0, then we are downloading Terraform 1.1.0 - but this is not the version of the mixin itself
What is being proposed is to specify the mixin version, so for instance:

mixin:
    terraform: 
     clientVersion: 1.1.0
     version: 1.0

As discussed this would be a schema change. We will have to add a function that checks what mixins are installed and if the version we want is installed. We currently have this function which we may be able to dive into and extend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Idea for maintainers to consider. Do not take this issue until triaged.
Projects
Development

No branches or pull requests

2 participants